Breathe keyword #90
Merged
Breathe keyword #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `breathe` keyword makes an actor "come up for air": it will check whether any thieves are trying to steal work from an actor and cooperate (if that is the case). The return type is `void`. The test just checks that nothing crashes, as breathe doesn't have any visible side effects, nor a return value.
| return $ Skip (meta pos) | ||
| breathe = do pos <- getPosition | ||
| reserved "breathe" | ||
| return $ Breathe (meta pos) |
There was a problem hiding this comment.
An alternative here would be to use the desugarer to convert a VarAccess of breathe to a Breathe node. But that can be a later refactoring.
There was a problem hiding this comment.
but then you could have variables called breathe and confusion would ensue, no?
|
Some whitespace removal that added noise to the pull request, but the actual changes look good! Merging |
Testing the limits :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
breathekeyword makes an actor "come up for air": it will checkwhether any thieves are trying to steal work from an actor and
cooperate (if that is the case). The return type is
void.The test just checks that nothing crashes, as breathe doesn't have
any visible side effects, nor a return value.